ci(renovate): add markers for remaining tools (almost) - #392
Conversation
cert-manager-prow
Bot
added
do-not-merge/work-in-progress
51cd5ff to
586dc70
Compare
Signed-off-by: Erik Godding Boye
586dc70 to
aa3c129
Compare
erikgb
changed the title
cert-manager-prow
Bot
removed
the
do-not-merge/work-in-progress
|
@inteon, I think we need your valuable input on this one! 🙏 |
|
I am thinking we might need data source templates for the envtest since they are packaged separately as tags/releases |
|
@hjoshi123 Did you read the description. We could use https://raw.githubusercontent.com/kubernetes-sigs/controller-tools/master/envtest-releases.yaml as input to Renovate, I think. And maybe https://docs.renovatebot.com/modules/manager/jsonata/. Well, not exactly. ChatGPT suggests something like this might work: {
"customDatasources": {
"envtest": {
"defaultRegistryUrl": "https://raw.githubusercontent.com/kubernetes-sigs/controller-tools/master/envtest-releases.yaml",
"format": "yaml"
}
},
"regexManagers": [
{
"fileMatch": ["(^|/)Makefile$"],
"matchStrings": [
// Example: ENVTEST_K8S_VERSION=1.30.0
"ENVTEST_K8S_VERSION=(?<currentValue>.+)\\n"
],
"datasourceTemplate": "custom.envtest",
"depNameTemplate": "kubernetes"
}
]
} |
|
yup that's what I was thinking @erikgb. We use a customDataSource with the file use |
|
You are welcome to contribute this in a follow-up PR, if you can. |
|
You can also try using extractVersion to get tags without a prefix for a given package, for example: {
"packageRules": [
{
"matchPackageNames": ["bar"],
"extractVersion": "^release-(?<version>.*)$"
}
]
} |
| # https://pkg.go.dev/github.com/google/go-licenses/v2?tab=versions | ||
| tools += go-licenses=e4be799587800ffd119a1b419f13daf4989da546 | ||
| # renovate: datasource=go packageName=github.com/inteon/go-licenses/v2 | ||
| tools += go-licenses=v2.0.0-20250821024731-e4be79958780 |
There was a problem hiding this comment.
Not sure this will work, will renovate update pseudo versions?
Do you have docs/ experiment or do you just want to try and see?
There was a problem hiding this comment.
I am pretty sure this will work. With the current configuration, the pseudo-version upgrades is configured to require dependency dashboard approval. See example here: cert-manager/cert-manager#7924.
|
I feel this should be okay to merge now and then I can create a follow up PR for the env test with a customDataSource |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
4 participants
This adds missing Renovate markers for almost all versions in the tools module. I have replaced Go package digests with pseudo-versions, as I find them more human-readable and simpler to reason about. Also added some comments here and there.
I have still not found a good way of picking up the envtest releases, for example: https://github.com/kubernetes-sigs/controller-tools/releases/tag/envtest-v1.34.0. We can probably configure a custom Renovate manager for it, based on the link to the YAML file with releases documented here.
Note: I have tested this with both cert-manager and trust-manager.